Skip to content

fix(motor-control): only add a delay before disengaging motor if ebrake exists #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix(motor-control): only add a delay before disengaging motor if ebrake exists #734

merged 3 commits into from
Nov 28, 2023

Conversation

ahiuchingau
Copy link
Contributor

We shouldn't have added the delay if the ebrake doesn't exist.

Also fixing an old commit message to actually show what it does.

sfoster1
sfoster1 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if it works! We're just squash merging this, right? We shouldn't retroactively change the commit around.

@ahiuchingau
Copy link
Contributor Author

Yes will be squash-merging this guy once i get it tested.

@ahiuchingau ahiuchingau merged commit de7fbaf into main Nov 28, 2023
@ahiuchingau ahiuchingau deleted the fix_only-add-delay-if-ebrake-exists branch November 28, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahiuchingau @sfoster1